File Coverage

File:blib/lib/indirect.pm
Coverage:100.0%

linestmtbrancondsubpodtimecode
1package indirect;
2
3
14
14
14
14
1076026
31
302
use 5.008001;
4
5
14
14
14
14
42
13
205
use strict;
6
14
14
14
14
38
21
538
use warnings;
7
8 - 16
=head1 NAME

indirect - Lexically warn about using the indirect object syntax.

=head1 VERSION

Version 0.24

=cut
17
18our $VERSION;
19BEGIN {
20
14
14
1088
 $VERSION = '0.24';
21}
22
23 - 60
=head1 SYNOPSIS

    # In a script
    no indirect;
    my $x = new Apple 1, 2, 3; # warns
    {
     use indirect;
     my $y = new Pear; # ok
     {
      no indirect hook => sub { die "You really wanted $_[0]\->$_[1] at $_[2]:$_[3]" };
      my $z = new Pineapple 'fresh'; # croaks 'You really wanted Pineapple->new at blurp.pm:13'
     }
    }
    try { ... }; # warns

    no indirect ':fatal';    # or 'FATAL', or ':Fatal' ...
    if (defied $foo) { ... } # croaks, note the typo

    # From the command-line
    perl -M-indirect -e 'my $x = new Banana;' # warns

    # Or each time perl is ran
    export PERL5OPT="-M-indirect"
    perl -e 'my $y = new Coconut;' # warns

=head1 DESCRIPTION

When enabled (or disabled as some may prefer to say, since you actually turn it on by calling C<no indirect>), this pragma warns about indirect object syntax constructs that may have slipped into your code.

This syntax is now considered harmful, since its parsing has many quirks and its use is error prone (when C<swoosh> is not defined, C<swoosh $x> actually compiles to C<< $x->swoosh >>).
In L<http://www.shadowcat.co.uk/blog/matt-s-trout/indirect-but-still-fatal>, Matt S. Trout gives an example of an indirect construct that can cause a particularly bewildering error.

It currently does not warn for core functions (C<print>, C<say>, C<exec> or C<system>).
This may change in the future, or may be added as optional features that would be enabled by passing options to C<unimport>.

This module is B<not> a source filter.

=cut
61
62BEGIN {
63
14
100
14
47
 if ($ENV{PERL_INDIRECT_PM_DISABLE}) {
64
1
1
1
3
4
  *_tag = sub ($) { 1 };
65
1
1
  *I_THREADSAFE = sub () { 1 };
66
1
208
  *I_FORKSAFE = sub () { 1 };
67 } else {
68
13
37
  require XSLoader;
69
13
6207
  XSLoader::load(__PACKAGE__, $VERSION);
70 }
71}
72
73 - 98
=head1 METHODS

=head2 C<< unimport [ hook => $hook | ':fatal', 'FATAL', ... ] >>

Magically called when C<no indirect @opts> is encountered.
Turns the module on.
The policy to apply depends on what is first found in C<@opts> :

=over 4

=item *

If it is a string that matches C</^:?fatal$/i>, the compilation will croak on the first indirect syntax met.

=item *

If the key/value pair C<< hook => $hook >> comes first, C<$hook> will be called for each error with a string representation of the object as C<$_[0]>, the method name as C<$_[1]>, the current file as C<$_[2]> and the line number as C<$_[3]>.
If and only if the object is actually a block, C<$_[0]> is assured to start by C<'{'>.

=item *

Otherwise, a warning will be emitted for each indirect construct.

=back

=cut
99
100sub unimport {
101
2991
2991
1
1469107
 shift;
102
103
2991
2620
 my $hook;
104
2991
5674
 while (@_) {
105
1020
937
  my $arg = shift;
106
1020
100
100
1784
  if ($arg eq 'hook') {
107
1010
991
   $hook = shift;
108  } elsif ($arg =~ /^:?fatal$/i) {
109
8
3
3
25
5
   $hook = sub { die msg(@_) };
110  }
111
1020
100
1778
  last if $hook;
112 }
113
2991
304
100
304
8050
3422
 $hook = sub { warn msg(@_) } unless defined $hook;
114
115
2991
4274
 $^H |= 0x00020000;
116
2991
8798
 $^H{+(__PACKAGE__)} = _tag($hook);
117
118
2991
103359
 ();
119}
120
121 - 125
=head2 C<import>

Magically called at each C<use indirect>. Turns the module off.

=cut
126
127sub import {
128
1967
1967
688217
 $^H{+(__PACKAGE__)} = undef;
129
1967
138171
 ();
130}
131
132 - 138
=head1 FUNCTIONS

=head2 C<msg $object, $method, $file, $line>

Returns the default error message generated by C<indirect> when an invalid construct is reported.

=cut
139
140sub msg {
141
307
307
1
349
 my $obj = $_[0];
142
143
307
100
3480
 join ' ', "Indirect call of method \"$_[1]\" on",
144           ($obj =~ /^\s*\{/ ? "a block" : "object \"$obj\""),
145           "at $_[2] line $_[3].\n";
146};
147
148 - 233
=head1 CONSTANTS

=head2 C<I_THREADSAFE>

True iff the module could have been built with thread-safety features enabled.

=head2 C<I_FORKSAFE>

True iff this module could have been built with fork-safety features enabled.
This will always be true except on Windows where it's false for perl 5.10.0 and below .

=head1 DIAGNOSTICS

=head2 C<Indirect call of method "%s" on object "%s" at %s line %d.>

The default warning/exception message thrown when an indirect call on an object is found.

=head2 C<Indirect call of method "%s" on a block at %s line %d.>

The default warning/exception message thrown when an indirect call on a block is found.

=head1 ENVIRONMENT

=head2 C<PERL_INDIRECT_PM_DISABLE>

If this environment variable is set to true when the pragma is used for the first time, the XS code won't be loaded and, although the C<'indirect'> lexical hint will be set to true in the scope of use, the pragma itself won't do anything.
In this case, the pragma will always be considered to be thread-safe, and as such L</I_THREADSAFE> will be true.
This is useful for disabling C<indirect> in production environments.

Note that clearing this variable after C<indirect> was loaded has no effect.
If you want to re-enable the pragma later, you also need to reload it by deleting the C<'indirect.pm'> entry from C<%INC>.

=head1 CAVEATS

The implementation was tweaked to work around several limitations of vanilla C<perl> pragmas : it's thread safe, and does not suffer from a C<perl 5.8.x-5.10.0> bug that causes all pragmas to propagate into C<require>d scopes.

Before C<perl> 5.12, C<meth $obj> (no semicolon) at the end of a file is not seen as an indirect object syntax, although it is as soon as there is another token before the end (as in C<meth $obj;> or C<meth $obj 1>).
If you use C<perl> 5.12 or greater, those constructs are correctly reported.

With 5.8 perls, the pragma does not propagate into C<eval STRING>.
This is due to a shortcoming in the way perl handles the hints hash, which is addressed in perl 5.10.

The search for indirect method calls happens before constant folding.
Hence C<my $x = new Class if 0> will be caught.

=head1 DEPENDENCIES

L<perl> 5.8.1.

A C compiler.
This module may happen to build with a C++ compiler as well, but don't rely on it, as no guarantee is made in this regard.

L<XSLoader> (standard since perl 5.006).

=head1 AUTHOR

Vincent Pit, C<< <perl at profvince.com> >>, L<http://www.profvince.com>.

You can contact me by mail or on C<irc.perl.org> (vincent).

=head1 BUGS

Please report any bugs or feature requests to C<bug-indirect at rt.cpan.org>, or through the web interface at L<http://rt.cpan.org/NoAuth/ReportBug.html?Queue=indirect>.
I will be notified, and then you'll automatically be notified of progress on your bug as I make changes.

=head1 SUPPORT

You can find documentation for this module with the perldoc command.

    perldoc indirect

Tests code coverage report is available at L<http://www.profvince.com/perl/cover/indirect>.

=head1 ACKNOWLEDGEMENTS

Bram, for motivation and advices.

Andrew Main and Florian Ragwitz, for testing on real-life code and reporting issues.

=head1 COPYRIGHT & LICENSE

Copyright 2008,2009,2010,2011 Vincent Pit, all rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.

=cut
234
2351; # End of indirect